[TM-2517] enable approval frow for disturbance report #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roguenet
reviewed
Oct 14, 2025
| entries: DisturbanceReportEntryDto[] | null; | ||
|
|
||
| @ApiProperty({ type: Number }) | ||
| disturbanceableId: number; |
There was a problem hiding this comment.
Two things:
- Shouldn't this be nullable? If I remember correctly, we've made this field nullable because of the change in how we're relating disturbances.
- This field is kind of meaningless without the type as well. Even if you don't think you need it for your current ticket, it should be included.
apps/entity-service/src/entities/processors/disturbance-report.processor.ts
Show resolved
Hide resolved
apps/entity-service/src/entities/processors/disturbance-report.processor.ts
Show resolved
Hide resolved
apps/entity-service/src/entities/processors/entity-processor.ts
Outdated
Show resolved
Hide resolved
roguenet
approved these changes
Oct 14, 2025
LimberHope
deleted the
TM-2517-enable-the-approval-flow-of-disturbance-reports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Link